On 16/12/2023 15:38, Daisuke Fujimura via Cygwin-apps wrote:
I have implemented a curl-based smart transport check. How about this one?
Thanks. Again, sorry about my terrible slowness in reviewing this.
diff --git a/cygclass/git.cygclass b/cygclass/git.cygclass index e53a7985..f3ed343e 100644 --- a/cygclass/git.cygclass +++ b/cygclass/git.cygclas
[...]
+ check_prog_req curl + curl -is ${GIT_URI}/info/refs?service=git-upload-pack | grep --binary-files=text -i '^content-type:\sapplication/x-git-upload-pack'& /dev/null && _branch="${_depth} ${_branch}"+
It seems like this is going to give a false negative on 'git://' transport URLs?
Maybe we should check if GIT_URI starts 'http(|s)://' ?
