On Mon, Oct 29, 2007 at 09:48:16PM +0100, Christoph Mallon wrote: > Andrey A. Chernov wrote: > >ache 2007-10-27 22:32:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > include _ctype.h > > Log: > > Micro-optimization of prev. commit, change > > (_c < 0 || _c >= 128) to (_c & ~0x7F) > > > > Revision Changes Path > > 1.33 +1 -1 src/include/_ctype.h > > Further IMO it is hard to decipher what _c & ~0x7F is supposed to do.
Seconded. Messing with bits should be avoided when their use masks out the logic behind. Nowadays it's almost always better to trust the compiler to do its optimizing job. ./danfe _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
