On Tuesday 16 October 2007 06:19:03 pm Olivier Houchard wrote: > On Tue, Oct 16, 2007 at 04:37:36PM -0400, John Baldwin wrote: > > On Tuesday 16 October 2007 03:57:36 pm Olivier Houchard wrote: > > > cognet 2007-10-16 19:57:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > sys/sys proc.h > > > Log: > > > Make td_sqqueue explicitely signed, as we compare it with >= 0. On arm, > > > char defaults to unsigned. > > > > It probably should really be unsigned like td_tsqueue (serves the same > > purpose) FWIW, however it is currently an 'int' in HEAD. > > > > Probably changing td_sqqueue to u_char in HEAD, 7.x and 6.x would be the best > > fix. > > I didn't investigate much. I saw it was an int on -CURRENT, and this test : > MPASS(td->td_sqqueue < NR_SLEEPQS && td->td_sqqueue >= 0); > If td_squeue can be unsigned, the test is wrong.
Yeah, it might be. It's meant to be an array index, so negative values really are meaningless. I'll fix it in HEAD if I get some time. -- John Baldwin _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
