On Wed, Jul 04, 2007 at 05:22:27PM +0800, Rong-En Fan wrote:
> On Wed, Jul 04, 2007 at 09:09:51AM +0000, Alexey Dokuchaev wrote:
> > On Wed, Jul 04, 2007 at 05:06:51AM +0000, Rong-En Fan wrote:
> > > rafan 2007-07-04 05:06:51 UTC
> > >
> > > FreeBSD ports repository
> > >
> > > Modified files:
> > > net-p2p/verlihub Makefile distinfo
> > > Log:
> > > - Set WRKSRC to remove ugly post-extract hack [1]
> >
> > Does not seem right to me. The error would appear on install stage
> > (more specifically, apply-slist one). Please see my reply to Andrew's
> > mail. Whenever you see a hack, it might be put there deliberately.
>
> Okay, I see what happens when doing a tinderbox build.
> I will back out this one.
Thanks.
>
> > I was also under impression that we normally give comitter a chance to
> > backout their changes themself, no?
>
> I'm sorry about this. I just want to keep minimal changes
> as I'm going to commit the plugins later. In that PR
Well, in this case the changes seem minimal to me. Taking care of
verlihub.in would require *both* ${MV} and custom WRKSRC.
> it also has some patches for this port.
As you might guessed, I've seen the PR. The problem I described is
taken care of, but personally I did not quite like their fix.
What would be the truly right thing to do here is to ask vendor to
correctly roll tarball next time. :-)
./danfe
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
