On Sun, 13 May 2007, Wojciech A. Koszek wrote:

 Log:
 Bump config(8) version and build requirement for config(8) to 600006. This
 is caused by my latest changes to config(8). You're supposed to install new
 config(8) in order to prevent yourself from seeing a warning about old
 version of that tool.

 You should configure the kernel with a new config(8) then.

 Oked by:        rwatson, cognet (mentor)

In typical FreeBSD parlance, we use one or both of:

Reviewed by:    whomever
Approved by:    whomever

The former states that the persons(s) in question have at least read, and possibly also tested, the changes, and is vouching for their reasonableness.

The latter states that the person(s) in question have authorized a commit, typically in the role of a subsystem maintainer, mentor, release engineer, or security officer. Sometimes it comes in the form:

Approved by:    re (whomever)
Approved by:    security-officer (whomever)
Approved by:    whomever (mentor)

I don't claim that this is consistent. :-)

I've noticed an increasing number of "OKed" commits lately -- I'd prefer it if we stuck to our existing nomenclature with respect to how we annotate changes with respect to review and approval. Among other things, it makes the commit messages more mechanically parseable, and avoids ambiguity.

Robert N M Watson
Computer Laboratory
University of Cambridge



 Revision  Changes    Path
 1.23      +1 -1      src/sys/conf/Makefile.amd64
 1.32      +1 -1      src/sys/conf/Makefile.arm
 1.272     +1 -1      src/sys/conf/Makefile.i386
 1.68      +1 -1      src/sys/conf/Makefile.ia64
 1.174     +1 -1      src/sys/conf/Makefile.pc98
 1.284     +1 -1      src/sys/conf/Makefile.powerpc
 1.39      +1 -1      src/sys/conf/Makefile.sparc64
 1.2       +1 -1      src/sys/conf/Makefile.sun4v
 1.45      +1 -1      src/usr.sbin/config/configvers.h

_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to