The reason you make it static is so that when you add another file to the build, there is no need to track down what should be static.
* Brian Somers <[EMAIL PROTECTED]> [070410 09:49] wrote: > On Tue, 10 Apr 2007 16:42:56 +0930 > "Greg 'groggy' Lehey" <[EMAIL PROTECTED]> wrote: > > > On Tuesday, 10 April 2007 at 9:00:42 +0200, Dag-Erling Smrgrav wrote: > > > Greg 'groggy' Lehey <[EMAIL PROTECTED]> writes: > > >> On Monday, 9 April 2007 at 12:16:47 +0200, Dag-Erling Smrgrav wrote: > > >>> The latter part is incorrect and should be reverted. Furthermore, > > >>> usage() should be static. > > >> Can you give details? > > > > > > usage() should be the way it was before your commit, except that it > > > should be static. > > > > You mean declared as a static function? In a program of a single > > file? > > > > As I said before, > > > > >> Can you give details? > > > > Specifically, this doesn't match my recollection of "good practice". > > Where is this behaviour mandated? > > Bump WARNS? Every function should be either prototyped > or declared static (or both). > > -- > Brian Somers <[EMAIL PROTECTED]> > Don't _EVER_ lose your sense of humour ! <[EMAIL PROTECTED]> -- - Alfred Perlstein _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
