On Sat, Apr 07, 2007 at 08:40:22PM +0400, Andrey Chernov wrote: > On Sat, Apr 07, 2007 at 04:02:31PM +0000, Pawel Jakub Dawidek wrote: > > - Only define SEEK_DATA and SEEK_HOLE in sys/unistd.h when neither > > _POSIX_SOURCE nor _XOPEN_SOURCE is defined. > > 1) This new addition should be exluded for !define(_C99_SOURCE) > !define(_ANSI_SOURCE) !define(_POSIX_C_SOURCE) too. > > 2) We design our *_VISIBLE framework right for the reason to not mention > all possible *_SOURCE each time like this, making includes unnecessary big > and hard to adapt to the future *_SOURCE tags, but mention one *_VISIBLE > tag instead, so please rewrite this thing using it.
That's why I asked for help. _CDDL_VISIBLE is not good, because it is
not related to CDDL license. _ZFS_VISIBLE is not good, because it is not
ZFS-specific. _{SUN,SOLARIS,OPENSOLARIS}_VISIBLE is also not good,
because it is already in Linux too. Solaris simply defines
__EXTENSIONS__. Maybe we need something like this? I don't think we need
separate _*_VISIBLE defines for every new #define in unistd.h and other
headers, so something similar to __EXTENSIONS__ makes sense to me.
--
Pawel Jakub Dawidek http://www.wheel.pl
[EMAIL PROTECTED] http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
pgpsyOcPxEkEE.pgp
Description: PGP signature
