Doug Barton wrote:
> 5. In vpnc_start() you could simplify the code by doing:
> 
> if ! $command $current $vpnc_flags; then
>       status=$?
>       echo "Running 'vpnc $current $vpnc_flags' failed."
>       return $status
> fi

That was a really bad idea, because it causes status to always be 0. Which is 
probably not the right thing to return in case of an error.
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to