John Baldwin wrote at 16:25 +0000 on Feb 23, 2007: > jhb 2007-02-23 16:25:08 UTC > > FreeBSD src repository > > Modified files: > sys/compat/ndis kern_ndis.c > sys/dev/acpica/Osd OsdSchedule.c > sys/dev/ata ata-all.c atapi-cd.c atapi-tape.c > sys/dev/ppc ppc.c > Log: > Use 'pause' in several places rather than trying to tsleep() on NULL (which > triggers a KASSERT) or local variables. In the case of kern_ndis, the > tsleep() actually used a common sleep address (curproc) making it > susceptible to a premature wakeup.
Nice. Maybe you should pass in priority so pause(9) users don't always wake up at PRI_MIN. If not, PZERO might be a more sensible default perhaps. PCATCH complicates this slightly since pause(9) currently returns nothing, but I could see cases where users might want PCATCH. _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
