On Tuesday 20 February 2007 16:45, Luigi Rizzo wrote: > luigi 2007-02-20 15:45:59 UTC > > FreeBSD src repository > > Modified files: > sys/dev/iwi if_iwi.c if_iwivar.h > Log: > Address a few issues with the iwi driver, namely: ... > + add debugging code IWI_LOCK_ASSERT() to detect missing locks. > These only do a printf, and should go away once we figure out why > the driver sometimes freezes the system due to a (yet unidentified) > race condition. > > + add a device_printf() in iwi_ioctl() in certain conditions > (see comment in the code). This helps preventing the race > condition mentioned above, and makes the system survive. This printf > will also go away once fixing this bug is completed. ... > The bugs fixed by this commit (the freezing one especially) are > serious enough to call for a quick MFC
... but since it is only a stopgap sollution, shouldn't we try to figure this out in HEAD and MFC the proper sollution once we found it? > MFC after: 3 days > > Revision Changes Path > 1.47 +127 -78 src/sys/dev/iwi/if_iwi.c > 1.13 +20 -0 src/sys/dev/iwi/if_iwivar.h -- /"\ Best regards, | [EMAIL PROTECTED] \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | [EMAIL PROTECTED] / \ ASCII Ribbon Campaign | Against HTML Mail and News
pgpplN8nUrNZP.pgp
Description: PGP signature
