> > Removing the "dead" assignment to evl->evl_encap_proto above and > reducing the bcopy window by 2 bytes here is a nano-optimization. > Which is worse, it smuggles hidden dot1q details in this otherwise > encapsulation-neutral block of code. E.g., I could use the former > code for both dot1q and ISL privately by just redefining > ETHER_VLAN_ENCAP_LEN. >
You are right. > > Grand total: I would greately appreciate if you backed out this > change and then fixed the tag value of -1 alone, but let me review > that first. Thanks! > Okay. Thanks, -- Qing _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
