Re: cvs commit: ports/graphics/png/files patch-aa

[Kris Kennaway]

On Mon, Apr 24, 2006 at 02:05:48PM -0700, Jeremy Chadwick wrote:
> On Mon, Apr 24, 2006 at 02:04:31PM -0400, Kris Kennaway wrote:
> > On Mon, Apr 24, 2006 at 02:04:09PM +0000, Andrey A. Chernov wrote:
> > > ache        2006-04-24 14:04:09 UTC
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     graphics/png/files   patch-aa 
> > >   Log:
> > >   Use NO_OBJ NO_PROFILE instead of obsoleted their variants
> > >   
> > >   PR:     96244
> > >   Submitted by:   Jeremy Chadwick <[EMAIL PROTECTED]>
> > 
> > Are you sure this works on old FreeBSD branches?
> 
> No, I did not test this.
> 
> Kris is right -- chances are it won't suffice for 4.x.  The modified
> port builds fine on my 4.x box, but obviously the ports/mk framework
> is expecting NOOBJ and NOPROFILE there.  I don't know of a way to
> test this (not sure what NOOBJ does, and profiling is completely
> disabled on all of my machines).
> 
> One solution for solving this dilemma would be to remove the NOOBJ
> and NOPROFILE lines completely from ${WRKSRC}/scripts/makefile.freebsd
> and utilise a check in the port Makefile for ${OSVERSION}, e.g.
> something like this:
> 
> .if ${OSVERSION} < 500000
> MAKE_ARGS+=   -DNOPROFILE -DNOOBJ
> .else
> MAKE_ARGS+=   -DNO_PROFILE -DNO_OBJ
> .endif

Either that (with correct OSVERSION) or just specify both variants at
once.

Kris

pgpBntHUWyBlf.pgp
Description: PGP signature