On 07/06/2012 21:39, Jason Helfman wrote: > On Fri, Jul 06, 2012 at 08:27:35PM +0000, George V. Neville-Neil thus > spake: >> gnn 2012-07-06 20:27:35 UTC >> >> FreeBSD ports repository (src committer) >> >> Added files: >> devel/zookeeper Makefile distinfo pkg-descr pkg-plist >> devel/zookeeper/files patch-src-c-src-zookeeper.c zookeeper >> Log: >> Initial commit of Apache Zookeeper a distributed coordination system. >> >> Approved by: skreuzer (mentor) >> >> Revision Changes Path >> 1.1 +79 -0 ports/devel/zookeeper/Makefile (new) >> 1.1 +2 -0 ports/devel/zookeeper/distinfo (new) >> 1.1 +21 -0 >> ports/devel/zookeeper/files/patch-src-c-src-zookeeper.c (new) >> 1.1 +33 -0 ports/devel/zookeeper/files/zookeeper (new) >> 1.1 +17 -0 ports/devel/zookeeper/pkg-descr (new) >> 1.1 +378 -0 ports/devel/zookeeper/pkg-plist (new) > > This seems to be broken, but I submitted a pr to fix it. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=169693
Furthermore the rc.d script is a mess, and should not have been committed like it was (numerous missing bits, bad format, set_rcvar, hard-coded /usr/local, no REQUIRE, no KEYWORD: shutdown, etc.). Please read http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html and then ask in freebsd-rc@ if you have any additional questions. Sorry to be so blunt, but I'm really, really tired of repeating the same stuff over and over again, and this script is really a mess. Also, don't install the script in do-install, see the web page above (and/or the PR) for USE_RC_SUBR. And FYI, there is no need to have the function in that script. You could use (for example) start_cmd="$command start" just as well. Not to mention that the function you have should be using $1 as the argument to $command, not $rc_arg. Reasons why left as an exercise for the reader ... Doug -- This .signature sanitized for your protection _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
