Steve asked me to review this but I haven't had (and am unlikely to
have) time to do a detailed review. So unfortunately this is after the
fact, my apologies.
The rc.d script should probably have KEYWORD: shutdown. The case
statement for _enable is probably sub-optimal, it doesn't seem to
support all of the things that checkyesno() does. Finally the 'unset
memcached_user' is almost certainly not necessary.
hth,
Doug
On 07/01/2011 15:33, Steve Wills wrote:
swills 2011-07-01 22:33:09 UTC
FreeBSD ports repository
Modified files:
databases/memcached Makefile
databases/memcached/files memcached.in
Log:
- add profiles support to init script
PR: ports/155533
http://www.FreeBSD.org/cgi/query-pr.cgi?pr=155533
Submitted by: swills
Approved by: maintainer timeout (mnag)
Revision Changes Path
1.48 +4 -2 ports/databases/memcached/Makefile
1.5 +52 -2 ports/databases/memcached/files/memcached.in
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/memcached/Makefile.diff?&r1=1.47&r2=1.48&f=h
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/memcached/files/memcached.in.diff?&r1=1.4&r2=1.5&f=h
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"