Christian Weisgerber <na...@freebsd.org> writes:
> naddy 2010-08-07 19:24:37 UTC
>
> FreeBSD ports repository
>
> Modified files:
> games/connect4 Makefile pkg-descr pkg-plist
> games/connect4/files patch-aa patch-ab patch-ac
> Log:
> Remove a bogus handrolled setproctitle() from ye olden days, fixes
> crashes on 64-bit archs. Add missing #includes.
>
> Move high-score file to /var/games.
>
> Better pkg-descr.
>
> PR: 149406
>
> Revision Changes Path
> 1.15 +8 -4 ports/games/connect4/Makefile
Why not pass $(SCOREFILE) to vendor makefile from port's one?
MAKE_ENV += SCOREFILE=${SCOREFILE}
It'll save one from keeping in mind *two* places where the value is
hardcoded.
Otherwise, I'm not the maintainer to complain about overriding
owner/group in INSTALL_(PROGRAM|DATA) rather than setting defaults.
> 1.3 +17 -30 ports/games/connect4/files/patch-aa
> 1.2 +83 -49 ports/games/connect4/files/patch-ab
> 1.2 +10 -23 ports/games/connect4/files/patch-ac
While converting diffs to unified formats you could have given patch
files more descriptive names, too. The effect would be mostly same for
`cvs annotate'.
> 1.3 +5 -7 ports/games/connect4/pkg-descr
> 1.5 +3 -2 ports/games/connect4/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
