On Sat, May 22, 2010 at 10:21:02AM +0300, Giorgos Keramidas wrote: > On Sat, 22 May 2010 06:37:51 +0000, Alexey Dokuchaev wrote: > > On Sat, May 22, 2010 at 08:52:03AM +0300, Giorgos Keramidas wrote: > >> Does this patch look ok? > > > > No, it does not. PORTEPOCH could never go backwards or be reset. It is > > the way we deal when version scheme changes so "newer" version is less > > than "old", or when for some reason port must be downgraded (yes, these > > things happen from time to time). > > > > You should have bumped PORTREVISION (wraps every version update, thus > > being cheap), but now it's probably too late: accidental errors like > > this should normally be reverted in a matter of minutes. > > > > Please refer to relevant PHB chapters for gory details, and be careful > > next time. > > Argh. So can we just commit the bsd.port.pre.mk bits? The OSVERSION > check is important for 6.X users.
Yeah, I guess they can be committed. But better ask maintainer first. I merely commented on PORTEPOCH vs. PORTREVISION issue. ./danfe _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
