On Thu, 20 Mar 2008, Doug Rabson wrote:

This function should have a WITNESS check at the top of it.

Can you add it?  If not I will unless you see a problem with it.

The various WITNESS_* macros appear to be undocumented and I'm not sure what they do. Perhaps it would be best if you added something.

I usually copy and paste it from another use, such as the sleep checks for the MAC Framework. When I do that, I often think to myself: wouldn't it be nice if we had a simple WITNESS_MAYSLEEP() macro to say "this code path may sleep, just do whateve ryou're going to do".

Robert N M Watson
Computer Laboratory
University of Cambridge
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to