Review: Approve
LGTM
Diff comments:
> diff --git a/tests/unittests/test_util.py b/tests/unittests/test_util.py
> index 4e268f0..3980055 100644
> --- a/tests/unittests/test_util.py
> +++ b/tests/unittests/test_util.py
> @@ -426,6 +426,9 @@ class TestHuman2Bytes(CiTestCase):
> GB = 1024 * 1024 * 1024
> MB = 1024 * 1024
>
> + def test_actually_an_int(self):
> + self.assertTrue(isinstance(util.human2bytes("1M"), int))
FYI there is
https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertIsInstance
> +
> def test_float_equal_int_is_allowed(self):
> self.assertEqual(1000, util.human2bytes(1000.0))
>
--
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/461402
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
