Review: Approve

Aaaah my confusion came from the names blkid uses differing depending on 
whether you use -p or not :(

This is fine. One quibble is that you say get_volume_id is a general function 
so it might be called with a disk directly -- but it's a general function with 
exactly one caller! curtin has a bit too much of that sort of thing already. 
But well, not a new thing here.

-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/460876
Your team curtin developers is subscribed to branch curtin:master.


-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to