Review: Needs Fixing
Unit tests please.
Diff comments:
> diff --git a/curtin/util.py b/curtin/util.py
> index 9ab4829..87a35db 100644
> --- a/curtin/util.py
> +++ b/curtin/util.py
> @@ -767,6 +777,12 @@ class ChrootableTarget(object):
> self.rc_tmp = None
> raise
>
> + # Symlink true to ischroot since we may be in separate PID
Comment is now out of date.
> + # namespace, which can throw off ischroot
> + ischroot_mount_path = paths.target_path(self.target,
> '/usr/bin/ischroot')
> + if do_mount('/usr/bin/true', ischroot_mount_path, opts='--bind'):
Can you address Dann's feedback by mounting the copy of /usr/bin/true from the
target instead of from the ephemeral environment?
> + self.umounts.append(ischroot_mount_path)
> +
> return self
>
> def __exit__(self, etype, value, trace):
--
https://code.launchpad.net/~mitchellaugustin/curtin/+git/curtin/+merge/460559
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
