Review: Needs Information Hi Mitchell, thanks for the proposal.
CI will be unhappy with the format of the commit message, so please update it for column wrapping rules. I think it's 50 chars for the first line and 72 for the body, I just do what Vim syntax highlighting tells me here. The change in question has been done in a broad manner - many many things calls subp(), this will hit all of them unless those specific calls have made a determination about unshare. What do you think about limiting the scope of this change of defaults to the subp in curtin/commands/in_target.py ? That would seem to address the issue raised by the bug report while leaving hundreds of other subp() users within curtin unaffected. -- https://code.launchpad.net/~mitchellaugustin/curtin/+git/curtin/+merge/460456 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
