On 12/22/20 2:43 AM, Daniel Stenberg wrote:
> On Mon, 21 Dec 2020, Dennis Clarke via curl-library wrote:
>
>> On 12/21/20 4:49 PM, Daniel Stenberg wrote:
>>> + if (/^\#\s*\z/) {
>>> + next;
>>> + }
>>
>> I applied that and test 1167 still fails :
>
> I modified the check in an update to just:
>
> if (/^#/) {
> next;
> }
>
> Does that fix the issue?
>
Let's give that a whirl :
alpha $ diff -u badsymbols.pl.orig badsymbols.pl
--- badsymbols.pl.orig Sun Dec 20 12:25:10 2020
+++ badsymbols.pl Tue Dec 22 17:02:03 2020
@@ -90,6 +90,9 @@
if($skipit) {
next;
}
+ if (/^#/) {
+ next;
+ }
if ( /enum\s+(\S+\s+)?{/ .. /}/ ) {
s/^\s+//;
chomp;
alpha $
That there is a thing of beauty :
alpha $ ./runtests.pl -p 1167
********* System characteristics ********
* curl 7.74.0 (sparc64-sun-solaris2.10)
* libcurl/7.74.0 OpenSSL/1.1.1i zlib/1.2.11 libidn2/2.3.0 libssh2/1.9.0
* Features: alt-svc AsynchDNS HTTPS-proxy IDN IPv6 Largefile libz NTLM
NTLM_WB SSL TLS-SRP UnixSockets
* Disabled:
* Host: alpha
* System: SunOS alpha 5.10 Generic_150400-65 sun4u sparc
SUNW,SPARC-Enterprise
* OS: solaris
* Servers: HTTP-IPv6 HTTP-unix FTP-IPv6
* Env:
* Seed: 211840
*****************************************
test 1167...[Verify curl prefix of public symbols in header files]
-------e--- OK (1 out of 1 , remaining: 00:00, took 0.485s, duration:
00:00)
TESTDONE: 1 tests out of 1 reported OK: 100%
TESTDONE: 1 tests were considered during 0 seconds.
alpha $
Also see attached log for perl -I. badsymbols.pl -v .. where we see :
.
.
.
Source: ../include/curl/system.h
Symbol: CURL_ISOCPP
Line #476: #define CURL_ISOCPP
3461 fine symbols found
alpha $
Wonderful !
--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional
badsymbols_patched_again.log.xz
Description: application/xz
------------------------------------------------------------------- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html
