Thanks for the review & remarks. Will keep it in mind ;) Btw, there's another thing to improve in this example - the file handles are not being synced/closed after the download, which of course causes that the downloaded content is partly truncated. Can fix it in some free time, if you'd like me to do that.
2014-10-07 10:23 GMT+02:00 Daniel Stenberg <dan...@haxx.se>: > On Tue, 7 Oct 2014, Waldek Kozba wrote: > > I've prepared the PR: https://github.com/bagder/curl/pull/119 >> > > Thanks, merged and pushed! > > Note for the future that I fixed for you now: > > - Your author info was wrong in the commit > - Some code format nits: You used trailing whitespace, had the brace on > the > function wrong and didn't declare the arguments (void). > - I edited the commit message to clarify what the change did > > > -- > > / daniel.haxx.se > ------------------------------------------------------------------- > List admin: http://cool.haxx.se/list/listinfo/curl-library > Etiquette: http://curl.haxx.se/mail/etiquette.html >
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html