On Tue, Jul 15, 2014 at 08:05:13PM +0100, Steve Holme wrote: > I don't know whether it is worth fixing these up before the release but I > noticed that the number of warnings in the OpenSuSE autobuilds has increased > from 18 to 30 at some point over the last few weeks. > > It seems that they are mainly due to HTTP2 calls in http.c that simply > #define a function to be -1 or a curl error code when the code doesn't > contain a condition.
It probably started with commit 740ebcd8. They're very likely harmless, and will be fixed once those TODOs are done. > For example: > > /* TODO: add error checking here */ > Curl_http2_switched(conn); > > Rather than: > > If(Curl_http2_switched(conn)) > return some_errorcode; That's the kind of thing I would expect needs doing. I'm not familiar with the right error handling strategy around this so I'll defer to those who are. >>> Dan ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
