On Wed, 24 Apr 2013, Dan Fandrich wrote:
On Wed, Apr 24, 2013 at 11:01:10PM +0200, Daniel Stenberg wrote:
4 - your change for CURLE_QUOTE_ERROR to become sftp_libssh2_error_to_CURLE()
is not really related to the new callback and I would ask you to submit that
as a separate patch (which we could merge at once)
I'm not entirely sure about this one. This would make it impossible to tell
when an error was due to a quote command or when it was due to a subsequent
file transfer. It's also worth checking if this would affect '*' prefixed
quote commands.
A very good point. We could however use the "real" error code to first make
libcurl log some details before returning the generic CURLE_QUOTE_ERROR...
--
/ daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
