Hi,
I initially wanted to summarize where we stand with pull requests, and
list those that should be okay to go in, and those that need further
review. But we reached a point where even doing this is just too
painful: there are 114 pull requests opened right now; I would estimate
that 90 of them or so are for roxy.
This is not sustainable.
Just to make this very understandable: we got something like 10 new pull
requests yesterday; and a similar amount on Monday.
We're still working on building the automatic smoketest infrastructure,
and this is clearly not moving as fast as we'd like. But in the
meantime, it seems that we're way past doing manual smoketesting, unless
we have people here who can take a full week for this.
So how do we move forward? There are several approaches:
a) find people who can do manual smoketesting of everything, fast.
=> I'm not sure there's anyone who can do this?
b) wait for the automatic smoketesting to be completed.
=> this is going to take some more time, I guess. And we can't wait
much more, so I don't think it's the right solution for now.
c) start merging things that got reviewed.
=> this might break stuff, but at least we can move forward, and fix
breakages that we hit
d) anything else?
At this point, I think we should just accept the fact that the current
rule of waiting for smoketesting is too strict, and we should go with c.
We're just artificially slowing down all progress because of this, and
this is hurting everyone. I'd guess that half of the pull requests are
already conflicting with each other, and it's only going to be worse
with time.
I believe we should start merging as many things as possible (as long as
they've been reviewed!). And if smoketesting breaks afterwards, we can
always fix things.
What do others think?
Vincent
--
Les gens heureux ne sont pas pressés.
_______________________________________________
Crowbar mailing list
Crowbar@dell.com
https://lists.us.dell.com/mailman/listinfo/crowbar
For more information: http://crowbar.github.com/
