Saascha, Please go ahead and merge your pull-request. It has been smoked and it is OK to move ahead. We have converged in agreement.
- John T. John H Terpstra Cloud Services Architect, Senior Principal Engineer Enterprise Solution Group +1 512 900-1654 | john_terps...@dell.com -----Original Message----- From: crowbar-bounces On Behalf Of Hirschfeld, Rob Sent: Tuesday, July 16, 2013 11:20 AM To: speili...@suse.com; crowbar Subject: Re: [Crowbar] Session store issues Sascha, I have concerns about making any core infrastructure changes in CB 1.x; however, the actual risk and overhead a pretty small because those are highly tested/stable components of Rails. While it does add some additional overhead to Crowbar's Rails' server, it's pretty minimal and contained. Like any new behavior, this may have subtle side effects that we need to be prepared to address; however, we've done this in CB2 and I do not remember any major issues. Rob -----Original Message----- From: crowbar-bounces On Behalf Of Sascha Peilicke Sent: Tuesday, July 16, 2013 3:18 AM To: crowbar Subject: [Crowbar] Session store issues Hi fellow crowbarians, recently I stumbled across a rather annoying issue with how currently (ab)use the session store. I won't repeat what's discussed at [1], but it's generating internal server errors (500), which are but the proposed solution would require using a persistent session store. I thought sqlite would be the obvious choice since we don't have a real DB setup this early (and we can't use the database barclamp). This should introduce any performance / storage issues since we don't expect many users to use the Crowbar UI in parallel ;-) Currently, there seem to exists some doubts about the (re)introduced database dependency. However, this change would happen on pebbles and there's no requirement to pull it into mesa (Dell's stable branch). Alternatively, it could be guarded with platform=="suse" checks if that's would be more acceptable. A totally different solution would be to not use the session store (through Rails' flash messages) for error messages regarding raw proposal JSON or to cut them mercilessly. However, errors in proposals are already hard to interpret for users, so this doesn't seem ideal to me. But maybe I missed something totally obvious, so let's discuss. [1] https://github.com/crowbar/barclamp-crowbar/pull/581 [2] https://github.com/crowbar/crowbar/pull/1863 -- Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/ _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/ _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
