My memory is beginning to trickle back on this one ... Vincent Untz (vu...@suse.com) wrote: > Le lundi 10 juin 2013, à 17:44 +0100, Adam Spiers a écrit : > > Vincent Untz (vu...@suse.com) wrote: > > > Le jeudi 30 mai 2013, à 13:10 +0200, Vincent Untz a écrit : > > > > Hi, > > > > > > > > While investigating a bug, I wondered about the differences between the > > > > "Delete" and "Reset" (which also seems to be called "Deallocate") > > > > actions in Crowbar.
Right - as you saw by now, I wrote the below patch (43aab2) a long time ago to try to make this clearer, obviously with limited success ;-/ But at least the ambiguity around "Reset" is gone, since normally "Reset" just means "press the Big Red Button on the front". > > > > The only doc I could really find is at > > > > https://github.com/crowbar/travis-ci-crowbar/blob/master/barclamps/crowbar/doc/userguide/using-crowbar.md > > > > and it says: > > > > > > > > Delete: Completely removes all records of the node from the Crowbar/Chef > > > > database. If a node is deleted, it is rediscovered when it reboots. > > > > > > > > Reset: Removes all the roles assigned to the node and re-image it back > > > > to an unallocated node. > > > > > > > > Do I understand it right that Reset is more or less like Delete, except > > > > that it re-allocates the node on next discovery? Yeah I think that's probably right. control.sh has: case $DHCP_STATE in reset|discovery) discover && hardware_install;; and NodeObject#set_state doesn't behave differently for either. > > > > If that's correct, the Deallocate name is, hrm, kind of weird > > > > because it's re-allocated. OK, so maybe I chose the wrong replacement word. Maybe "Rebuild", although that's too close to "Reinstall" for comfort. "Reallocate"? Open to ideas ... > > > > If that's not correct, then what's the difference? > > > > > > So, nobody knows? I guess it means we should just drop deallocate in > > > that case ;-) > > > > Does this help? > > > > https://github.com/crowbar/barclamp-crowbar/commit/43aab2 > > Not really :-) What's the difference between: > > "This will remove the current allocation from the node. Any subsequent > allocation will rebuild the node from scratch, causing any data to be > lost." > > and > > "This will remove all records of the node from the Crowbar / Chef > database. It will be rediscovered if it reboots." > > In both cases, the node will be rebuilt from scratch next time it gets > allocated. Yes but in the "Forget" case (formerly "Delete") you have to first manually allocate it. It's as if it was never part of Crowbar before, hence why I renamed it to "Forget". That could be useful if you aren't yet sure whether you want to re-add it into the cluster, whereas you'd use "Deallocate" if you know you want it immediately re-added. > Or does deallocate mean "if I'm reallocated, I will keep the > exact same roles as I had before", in which case this means "temporarily > disable". Ah, that's a different issue. I suspect that neither button will remove the node roles from any existing proposals. But my memory is still very shakey on this stuff, so all the above could be wrong ... _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
