cdearborn (notificati...@github.com) wrote: > Yes (I can't wait!). This helper should only be in the network > barclamp. Rob checked a copy of it into the crowbar barclamp as a > stop-gap to make the unit tests run. Wayne is working on updating > dev setup-unit-tests or barclamp_install or whatever to correctly > copy any test helpers that are defined in the engines to the correct > dev test location. Once he finishes that work, we can delete this > helper from the crowbar barclamp.
Great. Talking of duplicated code, it seems that crowbar_engine/barclamp_$BC/ is a modified and restructured copy of crowbar_framework/ for some or all of the barclamp engines. Whilst I know we still need to keep one or two of the old files in the very short term, such as the network helper referenced above, can't we already remove most of the non-engine files? Having a whole load of duplicated code hanging around risks someone reading or changing the wrong version by mistake, or worse, the old code actually being used somewhere ... sorry for being annoying or if I misunderstood something, but I'm even more religious about DRY than I am about emacs ;-) _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
