"What testing do we run before submitting?" is a key question; thanks
for bringing it up. Unfortunately the answer is currently "only
whatever we run manually", since Travis only runs on a merged
repository containing master from each barclamp repository, due to
barclamps currently being unable to run their unit tests standalone.
(There are Trello cards to address this, but it's unlikely to get
fixed soon.)
That means we all need to be as conscientous as possible by running
tests before every pull request, otherwise master is likely to break
often. I just spoke with James and agree with his proposal to
prototype barclamps as gems which can run their unit tests standalone
(I get the impression engines should help with this but I am not an
expert in the area). That would allow Travis to run on pull requests
to individual barclamp repos.
However unfortunately we can't prioritise that over the current dev
work, so for the next few weeks at very least I expect we will just
all have to be self-disciplined and not submit pulls for untested code ;-)
----- Forwarded message from arkadykanevsky <notificati...@github.com> -----
Date: Mon, 11 Mar 2013 10:40:31 -0700
From: arkadykanevsky <notificati...@github.com>
To: crowbar/barclamp-crowbar <barclamp-crow...@noreply.github.com>
Subject: Re: [barclamp-crowbar] fix BDD tests around node create [1/1] (#455)
Reply-To: crowbar/barclamp-crowbar
<reply+p-3321508-10658e30efd77c7995e1a231fa731b38052e3a26-100...@reply.github.com>
> @@ -72,21 +72,25 @@ def show
>
> # RESTful DELETE of the node resource
> def destroy
> - n = Node.find params
> - unless n.nil?
> - Jig.all.each {|j| j.delete_node(n)}
> - end
> + n = find_ndoe(params)
What testing do we run before submitting?
From: Victor Lowther [mailto:notificati...@github.com]
Sent: Monday, March 11, 2013 12:39 PM
To: crowbar/barclamp-crowbar
Subject: Re: [barclamp-crowbar] fix BDD tests around node create [1/1] (#455)
In crowbar_framework/app/controllers/nodes_controller.rb:
> @@ -72,21 +72,25 @@ def show
>
> # RESTful DELETE of the node resource
> def destroy
> - n = Node.find params
> - unless n.nil?
> - Jig.all.each {|j| j.delete_node(n)}
> - end
> + n = find_ndoe(params)
I am referring to the name of the function, not what it does (which was obvious
at a glance) -- you have it spelled as find_ndoe instead of find_node.
—
Reply to this email directly or view it on
GitHub<https://github.com/crowbar/barclamp-crowbar/pull/455/files#r3321448>.
---
Reply to this email directly or view it on GitHub:
https://github.com/crowbar/barclamp-crowbar/pull/455/files#r3321508
----- End forwarded message -----
_______________________________________________
Crowbar mailing list
Crowbar@dell.com
https://lists.us.dell.com/mailman/listinfo/crowbar
For more information: http://crowbar.github.com/
