In general I think the proposal is useful. On 14/07/2026 10:36, Arun Bhattacharya wrote:
+# Check that the output format has labels and values +grep "^kernel name : " out || fail=1 +grep "^nodename : " out || fail=1 +grep "^kernel-release : " out || fail=1 +grep "^kernel-version : " out || fail=1 +grep "^machine : " out || fail=1 +# processor and hardware-platform may be omitted if unknown +grep "^operating-system : " out || fail=1
I'd keep the label formats consistent. There are 3 different formats above, with spaces, no spaces, hyphens. Also I'd avoid a space before the : To be more consistent with other coreutils I'd use: Kernel name: ... Node name: ... Kernel release: ... ...
+# Ensure that standard uname output (e.g. uname -a) is unchanged +uname -a > out_std || fail=1 +# out_std should not contain " : " +if grep " : " out_std; then + fail=1 +fi
That seems a little brittle as " : " could be part of a version string etc. thanks, Padraig
