Pádraig Brady <p...@draigbrady.com> writes:
> Hi Bruno,
>
> Your two date patches look good.
> I'm replying directly since I can only see the messages in the archive,
> but they've not been delivered to me as of yet.
>
> (Generally GNU infra has been problematic over the last few months.
> Apparently this is due to ongoing DDOS as per https://hostux.social/@fsfstatus
> I asked for details on @fsfsys and the said the DDOS is still ongoing,
> and due to a mixture of malicious traffic, and careless scraping.)
Yep, sadly. It seems to be getting better recently, though? I didn't
even notice the outages that they recently posted about.
> I'll apply both in a few hours.
I ran into the following error when trying to test the patches on
OpenBSD and MacOS:
In file included from lib/hard-locale.c:19:
./lib/config.h:164:2: error: trailing whitespace
[-Werror=trailing-whitespace=]
164 |
./lib/config.h:3257:4: error: trailing whitespace
[-Werror=trailing-whitespace=]
3257 |
./lib/config.h:3406:20: error: trailing whitespace
[-Werror=trailing-whitespace=]
3406 | #define ICONV_CONST
./lib/config.h:5231:2: error: trailing whitespace
[-Werror=trailing-whitespace=]
5231 |
cc1: all warnings being treated as errors
This is because of the following change in one of the patches:
diff --git a/gnulib b/gnulib
index 84ddfc7bd..caf768863 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 84ddfc7bd29853ed91cdd65c7ce818072959f974
+Subproject commit caf768863e2a411ede373164e861b0bf6b707bcc
This is an older gnulib commit the pre-dates the -Wtrailing-whitespace
workarounds.
Therefore, I will probably modify the patch and push them before you do
if my testing goes well. (Hope you don't mind, just want to avoid that
old submodule being committed :P)
Collin
