Hi Berny,

Bernhard Voelker <m...@bernhard-voelker.de> writes:

> That is 2x bash syntax, and at least the == is flagged by:
>
>   maint.mk: use "test x = x", not "test x == x"
>   make: *** [maint.mk:1218: sc_prohibit_test_double_equal] Error 1

Oops, right.

> Better use expr(1) instead of $(( )).

I assumed $(( )) was fine since it can be found elsewhere in the tests.

> I'm also getting this failure here:
>
>   ++ LC_ALL=C
>   ++ date +%Y
>   + current_year=2025
>   + export LC_ALL=th_TH.UTF-8
>   + LC_ALL=th_TH.UTF-8
>   ++ date +%Y
>   + test 2025 == 2568
>   + fail=1

The gnulib submodule isn't updated yet to include Bruno's nstrftime
changes. I was being lazy and just using GNULIB_SRCDIR pointing to a
latest checkout.

>> +# All months that have 31 days end have names that end with "คม".
>> +for month in 01 03 05 07 08 10 12; do
>> +  date --date=$current_year-$month-01 +%B | grep คม$ || fail=1
> ____________________________________________________^^^

> Non-ascii characters are hard to use/read.
> I suggest checking for the UTF value instead - something like:
>
>   date ... | od -tx1z -w500 | grep -F '84 e0 b8 a1 0a'

Sounds good to me.

Thanks for checking.

Collin

Reply via email to