Hi *,

downstream fold(1) - with the I18N patches - exited 0 for 'fold enoent' for 20 
years (upstream unaffected).
Adding a test here.

Have a nice day,
Berny

-------- Forwarded Message --------
Subject:        Re: coreutils-9.4: problems with I18N patches [was: coreutils, 
utmp and systemd-logind]
Date:   Tue, 9 Jul 2024 08:30:42 +0200
From:   Lukáš Zaoral <lzao...@redhat.com>
To:     Bernhard Völker <m...@bernhard-voelker.de>



Hello Berny!
I have received a report and patch yesterday that fix a 15yo regression in 
fold(1) caused by the i18n patch:

* https://bugzilla.redhat.com/show_bug.cgi?id=2296201 
<https://bugzilla.redhat.com/show_bug.cgi?id=2296201>
* https://src.fedoraproject.org/rpms/coreutils/pull-request/16
<https://src.fedoraproject.org/rpms/coreutils/pull-request/16>

Regards,
Lukas
From 8f0e1a2fe7f3723229a764afd8664413142d1c82 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <m...@bernhard-voelker.de>
Date: Wed, 10 Jul 2024 09:07:27 +0200
Subject: [PATCH] tests: add fold(1) test for non-existent files

* tests/misc/fold.pl: Add 'enoent' test.
---
 tests/misc/fold.pl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/misc/fold.pl b/tests/misc/fold.pl
index 00b43624f..3a37840dc 100755
--- a/tests/misc/fold.pl
+++ b/tests/misc/fold.pl
@@ -22,6 +22,7 @@ use strict;
 
 # Turn off localization of executable's output.
 @ENV{qw(LANGUAGE LANG LC_ALL)} = ('C') x 3;
+my $prog = 'fold';
 
 my @Tests =
   (
@@ -29,6 +30,12 @@ my @Tests =
    ['s2', '-w4 -s', {IN=>"abcdef d\n"}, {OUT=>"abcd\nef d\n"}],
    ['s3', '-w4 -s', {IN=>"a cd fgh\n"}, {OUT=>"a \ncd \nfgh\n"}],
    ['s4', '-w4 -s', {IN=>"abc ef\n"}, {OUT=>"abc \nef\n"}],
+
+   # The downstream I18N patch made fold(1) exit with success for non-existing
+   # files since v5.2.1-1158-g3d3030da6 (2004) changed int to bool for booleans.
+   # The I18N patch was fixed only in July 2024.  (rhbz#2296201).
+   ['enoent', 'enoent', {EXIT => 1},
+     {ERR=>"$prog: enoent: No such file or directory\n"}],
   );
 
 my $save_temps = $ENV{DEBUG};
-- 
2.45.2

Reply via email to