On 04/07/2024 02:08, Collin Funk wrote:
Hi,
Recently there was a bug fix in Gnulib's tests/init.sh. I then noticed
many packages copy this manually from Gnulib. Bruno and I discussed the
proper way to import the file from Gnulib [1].
What do you think of the attached patch? Basically remove the file from
version control. Then add 'gnulib-tool --copy-file tests/init.sh' to
bootstrap_post_import_hook. That way every time ./bootstrap is invoked
the proper version is imported.
Collin
[1] https://lists.gnu.org/archive/html/bug-gnulib/2024-06/msg00245.html
I was wondering about that myself.
We previously discussed auto gnulib syncing at:
https://lists.gnu.org/r/coreutils/2018-12/msg00007.html
and providing a gnulib_sync target to support that.
That would give more control to each repo, and also
support catch 22 cases like syncing `bootstrap` itself,
and the COPYING file which really needs to be in each repo.
Re tests/init.sh we don't really need that control,
but I was worried other users may have issues with it not being in the repo.
I know uutils for example adjusts it, but I see now it does so after calling
./bootstrap:
https://github.com/uutils/coreutils/blob/a18c1329/util/build-gnu.sh#L125
So I'll apply this, as it's one less thing to worry about going forward.
thanks!
Pádraig
