I noticed 'src/temp-stream.c' includes <stdbool.h>. This should be
unnecessary since Gnulib defines in in config.h right?

Feel free to apply this patch unless I am missing something. The
following returns no other files:

$ find . -name '*.[ch]' | xargs grep -E 
'[[:blank:]]*#[[:blank:]]*include[[:blank:]]+<stdbool.h>'

Collin
From 31a9bc521f495613e3a911e3b040cf668af01f2f Mon Sep 17 00:00:00 2001
From: Collin Funk <collin.fu...@gmail.com>
Date: Tue, 16 Apr 2024 13:38:06 -0700
Subject: [PATCH] maint: Remove unnecessary stdbool.h include

* src/temp-stream.c: Don't include <stdbool.h> since it is defined in
config.h if the compiler does not support the C23 keyword.
---
 src/temp-stream.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/temp-stream.c b/src/temp-stream.c
index bce8564c9..8cfb73937 100644
--- a/src/temp-stream.c
+++ b/src/temp-stream.c
@@ -17,7 +17,6 @@
 
 #include <config.h>
 
-#include <stdbool.h>
 #include <stdio.h>
 
 #include "stdlib--.h"  /* For mkstemp that returns safer FDs.  */
-- 
2.44.0

Reply via email to