Pádraig Brady wrote: > > The ls/removed-directory test fails on FreeBSD 14.0. > > > > tests-suite.log from FreeBSD 14.0: > > > > > > FAIL: tests/ls/removed-directory > > ================================ > > > > diff -u /dev/null err > > --- /dev/null 1970-01-01 > > +++ err 1970-01-01 > > +ls: reading directory '.': No such file or directory > > FAIL tests/ls/removed-directory.sh (exit status: 1) > > It seems that readdir() on FreeBSD 14 is _not_ eating the ENOENT from > getdirentries(). > Attached is an extra check for that, that avoids the test in that case.
This patch is not good: - It skips the test on all platforms that don't have 'python' in $PATH. (Nowadays more platforms have 'python3'. The old name 'python' is not present on all platforms that have 'python3'.) - On FreeBSD 14.0, in an empty directory: $ python3.9 -c 'import os; os.listdir(".")' succeeds (exit code 0). In detail: $ python3.9 >>> import os >>> os.listdir(".") [] Conclusion: The python test does *not* actually test what you meant to test.