On 23/03/2024 10:18, Bernhard Voelker wrote:
On my openSUSE:Tumbleweed system, the info pages seem to have changed
the quoting style for the strftime for the conversion specifiers from
the good old '%a' or `%a' styles to ‘%a’.
$ info libc date calendar format | grep '^[^a-z%]*%.[^a-z%]*$' | od -tx1z |
sed 1q
0000000 20 20 20 20 20 e2 80 98 25 61 e2 80 99 0a 20 20 > ...%a.... <
Hence, the sc_strftime_check check gets skipped:
maint.mk: skipping sc_strftime_check: libc info not installed
0.03 strftime_check
What about changing the grep pattern to the above pattern, or is there a better
way?
diff --git a/cfg.mk b/cfg.mk
index 7da1a4b4a..6aa12b21b 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -437,7 +437,7 @@ extract_char = sed 's/^[^%][^%]*%\(.\).*/\1/'
sc_strftime_check:
@if test -f $(srcdir)/src/date.c; then \
if info libc date calendar format 2>/dev/null | \
- grep "^ *['\`]%.'$$" >$@-tmp; then \
+ grep '^[^a-z%]*%.[^a-z%]*$$' >$@-tmp; then \
{ echo N; echo q; $(extract_char) $@-tmp; }| sort \
>$@-info; \
grep '^ %. ' $(srcdir)/src/date.c | sort \
Have a nice day,
Berny
Interesting.
On Fedora 39 `info` only outputs the curly quotes in non C locales,
and this syntax check is run under the C locale.
Perhaps info is using $LANG instead of $LC_CTYPE on tumbleweed?
I confirmed your grep adjustment works under the C locale
so feel free to apply.
thanks!
Pádraig