I'm seeing this failure on the openSUSE build server: [ 513s] FAIL: tests/misc/date-debug [ 513s] =========================== ... [ 513s] + TZ=America/Lima [ 513s] + date --debug -d @1 [ 513s] + compare exp3 out3 [ 513s] + compare_dev_null_ exp3 out3 [ 513s] + test 2 = 2 [ 513s] + test xexp3 = x/dev/null [ 513s] + test xout3 = x/dev/null [ 513s] + return 2 [ 513s] + case $? in [ 513s] + compare_ exp3 out3 [ 513s] + diff -u exp3 out3 [ 513s] --- exp3 2017-03-10 00:17:23.843634722 +0000 [ 513s] +++ out3 2017-03-10 00:17:23.847634722 +0000 [ 513s] @@ -4,4 +4,4 @@ [ 513s] date: final: 1.000000000 (epoch-seconds) [ 513s] date: final: (Y-M-D) 1970-01-01 00:00:01 (UTC0) [ 513s] date: final: (Y-M-D) 1969-12-31 19:00:01 (output timezone TZ=-05:00) [ 513s] -Wed Dec 31 19:00:01 PET 1969 [ 513s] +Wed Dec 31 19:00:01 -05 1969 [ 513s] + fail=1
This is due to changing the timezone abbreviations of South America to numerical format [1] in brand new 'timezone-2017a': https://github.com/eggert/tz/commit/c9e6ef07cc It seems we cannot rely on the timezone abbreviations any longer in our tests. For now, I suggest to work around the current FP for the "America/Lima" test. WDYT? Have a nice day, Berny
>From dda77b4d1af2ab236bbc1a021d26b9df527d9ecf Mon Sep 17 00:00:00 2001 From: Bernhard Voelker <[email protected]> Date: Fri, 10 Mar 2017 02:22:16 +0100 Subject: [PATCH] tests: avoid FP of date-debug.sh with newer timezone-2017a * tests/misc/date-debug.sh (Test 3: timespec): Change the expected timezone abbreviation to numeric format, as this will be the result with a newer timezone package. To let the test pass with older timezone versions, change the actual output from "PET" to "-05" (for "America/Lima") there as well. --- tests/misc/date-debug.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/misc/date-debug.sh b/tests/misc/date-debug.sh index 48f4605..8d8ac2e 100755 --- a/tests/misc/date-debug.sh +++ b/tests/misc/date-debug.sh @@ -94,10 +94,14 @@ date: output timezone: -05:00 (set from TZ="America/Lima" environment value) date: final: 1.000000000 (epoch-seconds) date: final: (Y-M-D) 1970-01-01 00:00:01 (UTC0) date: final: (Y-M-D) 1969-12-31 19:00:01 (output timezone TZ=-05:00) -Wed Dec 31 19:00:01 PET 1969 +Wed Dec 31 19:00:01 -05 1969 EOF -TZ=America/Lima date --debug -d "$in3" >out3 2>&1 || fail=1 +TZ=America/Lima date --debug -d "$in3" >out3_t 2>&1 || fail=1 +# Since timezone-2017a, we get the numeric timezone abbreviations for +# South America. Fix the result in the case we have an older version. +# See https://github.com/eggert/tz/commit/c9e6ef07cc +sed '$s/ PET / -05 /' out3_t > out3 || framework_failure_ compare exp3 out3 || fail=1 ## -- 2.1.4
