On 08/30/2012 12:10 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
>> On 08/30/2012 01:14 AM, Jim Meyering wrote:
>>> Thanks for all the work.
>>>
>>> Would you please mail to me (or to the list) the concatenation of those
>>> patches
>
> Thanks again. I've begun looking at these changes, so here's
> some preliminary feedback.
>
> As expected, the build now seems faster.
> I haven't yet measured it.
>
IMHO, a proper measurement will be appropriate only once 'src/' has been
merged into the top-level as well.
> I've had to make a few changes:
>
> - "make distcheck" failed due to a typo in man/local.mk.
> I fixed that by s,dir/,man/, below.
>
Oops. I should have run a "make dist" at least ("make distcheck" fails
for me even on the master branch, so I didn't run it, although I tried
a VPATH build).
> - "make syntax-check" failed due to a long line and to a TAB
> followed by 8 spaces. To address the long line, rather than
> splitting the just-lengthened line, I preferred to factor out
> this definition:
>
> texi_files = $(srcdir)/doc/*.texi
>
OTOH, I had seen this, and I thought I had fixed it. I must have lost
the patch in the reshuffling and rebasing ... Sorry for the confusion.
Thanks,
Stefano
