On 02/08/2012 03:24 AM, Pádraig Brady wrote: > On 02/07/2012 12:33 AM, Eric Blake wrote: >> https://lists.gnu.org/archive/html/bug-gnulib/2012-02/msg00038.html >> detailed a couple of bugs in gnulib's canonicalize that were visible >> through coreutils' readlink, but only on systems where // is distinct >> from /. This particular test assumes that POSIX will be fixed to >> require canonicalization of a symlink containing just slashes will >> behave as if slashes separating the symlink from the rest of the >> name are elided (see http://austingroupbugs.net/view.php?id=541), >> as that is the only useful (and current) behavior on Cygwin. That is, >> >> ln -s / root >> ls root/dev >> >> must list the contents of /dev, not //dev. >>
>> +
>> +test -d /dev || framework_failure_
>
> Maybe just skip_ above?
Nah. POSIX requires /dev/null to exist, and you'd be hard-pressed to
find a system where this test fails.
>
> cool.
Good to hear; that means I now need to write up my realpath test for //.
Question before I push: Right now, we have:
tests/readlink/can-{e,f,m}
tests/readlink/rl-1
tests/misc/readlink-fp-loop
This feels inconsistent; should we be consolidating all readlink-related
tests into the same directory, and if so, which directory?
--
Eric Blake [email protected] +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
