On Tue, 2025-01-14 at 15:21 -0700, Compostella, Jeremy wrote: > Felix Singer <felixsin...@posteo.net> writes: > > > Hi Jeremy, > > > > I'm sorry for my late reply. Please don't write to the coreboot- > > gerrit@ > > list since it is only meant for Gerrit events. > > > > However, I think the issue here is that it is Gerrit sending these > > events and that email address is not registered on Gerrit and thus > > not > > linked to any account. So adding an unregistered email addresses > > won't > > send any emails to it. > > > > Accounts linked to one of the email addresses are then added to > > reviewers or CC. So as a workaround you could register an account > > with > > that email address on Gerrit and then it should work. > > - How do I register intel_coreboot_review...@intel.com in Gerrit?
I just remembered that I can set up an appropriate account for you, because I have administrator privileges. I forgot that.. Do you want me to do that? > - Do you mean that <https://review.coreboot.org/c/coreboot/+/85982> > would become unnecessary or would the "Subdirectories assigned to > sections override sections assigned to parent directories" behavior > still be in the way? I'm not sure, but I think subsections don't override parents. New people are just added, but no one can be removed. > - Would it make sense, instead of overriding, to add the list of > reviewers? For instance, shouldn't CLs matching both INTEL > PANTHERLAKE SOC and INTEL SUPPORT files aggregate the reviewer > list? I don't really understand that point, but I think that would require that sections can be overriden. Please correct me if I'm wrong. Felix > > > I've just checked the Gerrit settings and it's already in there. > > > > > > Felix > > > > > > > > On Fri, 2025-01-10 at 11:43 -0700, Compostella, Jeremy wrote: > > > > > > > > > > > > Hi, > > > I do not know who I should talk to so I am going to leverage the > > > mailing list. > > > I have been wondering: why have I not been looped in the review > > > 85827 > > > soc/intel/pantherlake: Refactor FSP-M params for debug message > > > control. > > > I looked at the MAINTAINERS file and I found the following > > > related > > > definitions. > > > > > > INTEL SUPPORT > > > R: Intel_Coreboot_Reviewers > > > <intel_coreboot_review...@intel.com> > > > S: Maintained > > > F: src/vendorcode/intel/ > > > F: src/cpu/intel/ > > > F: src/northbridge/intel/ > > > F: src/southbridge/intel/ > > > F: src/soc/intel/ > > > F: src/drivers/intel/ > > > F: src/include/cpu/intel/ > > > [...] > > > INTEL PANTHERLAKE SOC > > > M: Subrata Banik <subrataba...@google.com> > > > M: Kapil Porwal <kapilpor...@google.com> > > > M: Pranava Y N <pranav...@google.com> > > > S: Maintained > > > F: src/soc/intel/pantherlake/ > > > I am part of the Intel_Coreboot_Reviewers > > > <intel_coreboot_review...@intel.com> mailing list but I do not > > > see > > > Intel_Coreboot_Reviewers added to the CC section in gerrit which > > > probably explain why I did not get any email. > > > Our goal is to have Intel folks of this mailing list as reviewers > > > of > > > all the src/soc/intel/… changes. How can we achieve that ? > > > Regards, > > > > > > > > > – > > > Jeremy > > > One Emacs to rule them all > > > _______________________________________________ > > > coreboot mailing list -- coreboot@coreboot.org > > > To unsubscribe send an email to coreboot-le...@coreboot.org > > -- > Jeremy > One Emacs to rule them all > _______________________________________________ > coreboot mailing list -- coreboot@coreboot.org > To unsubscribe send an email to coreboot-le...@coreboot.org _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
