Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
4 new defect(s) introduced to coreboot found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1452260: (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/x4x/raminit_ddr23.c: 1850 in power_settings()
/src/northbridge/intel/x4x/raminit_ddr23.c: 1851 in power_settings()
________________________________________________________________________________________________________
*** CID 1452260: (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/x4x/raminit_ddr23.c: 1850 in power_settings()
1844 mchbar_clrsetbits32(0x24, 0xe0000000, 0x60000000);
1845 mchbar_clrsetbits32(0x44, 0x1fef0000, 0x6b0000);
1846 mchbar_write16(0x115, reg1);
1847 mchbar_clrsetbits32(0x117, 0xffffff, reg2);
1848 mchbar_write8(0x124, 0x7);
1849 /* not sure if dummy reads are needed */
>>> CID 1452260: (CONSTANT_EXPRESSION_RESULT)
>>> "*((u16 volatile *)0xfed1412a) & -65536 /* ~((uint16_t)~0) */" is
>>> always 0 regardless of the values of its operands. This occurs as the
>>> bitwise first operand of "|".
1850 mchbar_clrsetbits16(0x12a, ~0, 0x80);
1851 mchbar_clrsetbits8(0x12c, ~0, 0xa0);
1852 mchbar_clrbits16(0x174, 1 << 15);
1853 mchbar_clrsetbits16(0x188, 0x1f00, 0x1f00);
1854 mchbar_clrbits8(0x18c, 1 << 3);
1855 mchbar_setbits8(0x192, 1);
/src/northbridge/intel/x4x/raminit_ddr23.c: 1851 in power_settings()
1845 mchbar_clrsetbits32(0x44, 0x1fef0000, 0x6b0000);
1846 mchbar_write16(0x115, reg1);
1847 mchbar_clrsetbits32(0x117, 0xffffff, reg2);
1848 mchbar_write8(0x124, 0x7);
1849 /* not sure if dummy reads are needed */
1850 mchbar_clrsetbits16(0x12a, ~0, 0x80);
>>> CID 1452260: (CONSTANT_EXPRESSION_RESULT)
>>> "*((u8 volatile *)0xfed1412c) & -256 /* ~((uint8_t)~0) */" is always 0
>>> regardless of the values of its operands. This occurs as the bitwise first
>>> operand of "|".
1851 mchbar_clrsetbits8(0x12c, ~0, 0xa0);
1852 mchbar_clrbits16(0x174, 1 << 15);
1853 mchbar_clrsetbits16(0x188, 0x1f00, 0x1f00);
1854 mchbar_clrbits8(0x18c, 1 << 3);
1855 mchbar_setbits8(0x192, 1);
1856 mchbar_setbits8(0x193, 0xf);
** CID 1452259: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/ironlake/quickpath.c: 694 in late_quickpath_init()
________________________________________________________________________________________________________
*** CID 1452259: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/ironlake/quickpath.c: 694 in late_quickpath_init()
688 mchbar_write32(0x1274, 0x0);
689
690 if (deven & 8) {
691 mchbar_write16(0x1214, 0x320);
692 mchbar_write32(0x1600, 0x40000000);
693 mchbar_clrsetbits32(0x11f4, ~0, 1 << 28);
>>> CID 1452259: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "*((u16 volatile *)0xfed11230) & -65536 /* ~((uint16_t)~0) */" is
>>> always 0 regardless of the values of its operands. This occurs as the
>>> bitwise first operand of "|".
694 mchbar_clrsetbits16(0x1230, ~0, 1 << 15);
695 mchbar_write32(0x1400, 0x13040020);
696 mchbar_write32(0x1404, 0xe090120);
697 mchbar_write32(0x1408, 0x5120220);
698 mchbar_write32(0x140c, 0x5120330);
699 mchbar_write32(0x1410, 0xe090220);
** CID 1452258: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/ironlake/raminit.c: 3103 in chipset_init()
________________________________________________________________________________________________________
*** CID 1452258: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/ironlake/raminit.c: 3103 in chipset_init()
3097
3098 dmi_setup();
3099
3100 mchbar_write16(0x1170, 0xa880);
3101 mchbar_write8(0x11c1, 1 << 0);
3102 mchbar_write16(0x1170, 0xb880);
>>> CID 1452258: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "*((u8 volatile *)0xfed11210) & -256 /* ~((uint8_t)~0) */" is always 0
>>> regardless of the values of its operands. This occurs as the bitwise first
>>> operand of "|".
3103 mchbar_clrsetbits8(0x1210, ~0, 0x84);
3104
3105 if (get_option(&gfxsize, "gfx_uma_size") != CB_SUCCESS) {
3106 /* 0 for 32MB */
3107 gfxsize = 0;
3108 }
** CID 1452257: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/ironlake/raminit.c: 3076 in dmi_setup()
________________________________________________________________________________________________________
*** CID 1452257: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/northbridge/intel/ironlake/raminit.c: 3076 in dmi_setup()
3070
3071 static void dmi_setup(void)
3072 {
3073 gav(dmibar_read8(0x254));
3074 dmibar_write8(0x254, 1 << 0);
3075 dmibar_write16(0x1b8, 0x18f2);
>>> CID 1452257: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "*((u16 volatile *)0xfed10048) & -65536 /* ~((uint16_t)~0) */" is
>>> always 0 regardless of the values of its operands. This occurs as the
>>> bitwise first operand of "|".
3076 mchbar_clrsetbits16(0x48, ~0, 1 << 1);
3077
3078 dmibar_setbits32(0xd68, 1 << 27);
3079
3080 outl((gav(inl(DEFAULT_GPIOBASE | 0x38)) & ~0x140000) | 0x400000,
3081 DEFAULT_GPIOBASE | 0x38);
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq2SfQfrHt3Prsn4qSLrYIrajINpiFX8l0vrlNSf8iCrS27qY0Cr0DkycwNUgGZJj8-3DwbkQ_L-2FDzr14mnrsJO5b1wX1hp9b1MAQygl7x-2B74RAaH2cn1687A5E65Q2fmPVlL6xuQdDGFgXQ1hPgRjBHfI0imAufU4NDyNekGd43ykL99NjgOeqIWeAdpJG2xQIKXRaa59eYQCpS-2Fiv1tfDoKq-2FpOr9oD-2BDsC4YHthTZYMXYnwSa-2FDg-2FB-2B0-2BO-2BUqsAbpscu6wlVZuHaZoOCZdw9seVYxyWEQ-3D-3D
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org
