Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1445928: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/soc/amd/picasso/data_fabric.c: 178 in data_fabric_set_indirect_address()
________________________________________________________________________________________________________
*** CID 1445928: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/src/soc/amd/picasso/data_fabric.c: 178 in data_fabric_set_indirect_address()
172 {
173 uint32_t fabric_indirect_access_reg = DF_IND_CFG_INST_ACC_EN;
174 /* Register offset field [10:2] in this register corresponds to
[10:2] of the
175 requested offset. */
176 fabric_indirect_access_reg |= reg & DF_IND_CFG_ACC_REG_MASK;
177 fabric_indirect_access_reg |=
>>> CID 1445928: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(func << 11) & (28 /* 7 << 2 */)" is always 0 regardless of the values
>>> of its operands. This occurs as the bitwise operand of "|".
178 (func << DF_IND_CFG_ACC_FUN_SHIFT) &
DF_IND_CFG_ACC_FUN_MASK;
179 fabric_indirect_access_reg |= instance_id <<
DF_IND_CFG_INST_ID_SHIFT;
180 pci_write_config32(SOC_DF_F4_DEV, DF_FICAA_BIOS,
fabric_indirect_access_reg);
181 }
182
183 uint32_t data_fabric_read32(uint8_t function, uint16_t reg, uint8_t
instance_id)
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yq2SfQfrHt3Prsn4qSLrYIrajINpiFX8l0vrlNSf8iCrS27qY0Cr0DkycwNUgGZJj8-3D1-Op_L-2FDzr14mnrsJO5b1wX1hp9b1MAQygl7x-2B74RAaH2cn1oOR31weFd6fS90Zz6YAjup25FCqhuzX1PLYqPU29AhkxM0xub7IzKt6z8DWA0XgxQUEaHxyAhKG-2FWkM9H8Ct-2FduQwB4xaAKtahF-2FP2q2peUL4Xkevs-2BmiuW6RGRb5iJKB3iL0j2DsmK9E-2FImrHNnic4NOTJOGPeEBX0jNTcz3A1wZyzMsNcx035EJisUJvCs-3D
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org
