Hi Benjamin,
Enabling debug messages I've found something:
Loading driver FDFF263D-5F68-4591-87BA-B768F445A9AF
InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 8F3EE7C0
PDB =
/mnt/develop/bettong/coreboot/master/coreboot_tiano_master/payloads/external/tianocore/tianocore/Build/CorebootPayloadPkgX64/DEBUG_COREBOOT/X64/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe/DEBUG/Tcg2Dxe.dll
Loading driver at 0x0008F3D2000 EntryPoint=0x0008F3D2240 Tcg2Dxe.efi
InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 8F3EEA18
ProtectUefiImageCommon - 0x8F3EE7C0
- 0x000000008F3D2000 - 0x000000000000D800
PROGRESS CODE: V03040002 I0
WARNING: Tpm2RegisterTpm2DeviceLib - does not support
286BF25A-C2C3-408C-B3B4-25E6758B7317 registration
TPM2 not detected!
Error: Image at 0008F3D2000 start failed: Unsupported
PDB =
/mnt/develop/bettong/coreboot/master/coreboot_tiano_master/payloads/external/tianocore/tianocore/Build/CorebootPayloadPkgX64/DEBUG_COREBOOT/X64/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe/DEBUG/Tcg2Dxe.dll
PROGRESS CODE: V03040003 I0
I'll try to find more info about this warning and I'll try to see the code
where the TPM2 is detected in the edk2-staging branch
________________________________
De: coreboot <[email protected]> en nombre de Jorge Fernandez
Monteagudo <[email protected]>
Enviado: viernes, 21 de septiembre de 2018 13:01:23
Para: You, Benjamin; [email protected]
Asunto: Re: [coreboot] Tianocore and TPM
Hi,
I'll try modifying the Setup/Miscs/Setup.ini from
CustomizationSample/Boards/Qemu to enable ftpm
and generate an external payload but when boot with this coreboot.rom flashed I
only get a black
screen once the tianocore is executed with the next traces:
BS: BS_PAYLOAD_LOAD times (us): entry 0 run 101395 exit 0
Jumping to boot code at 006009a0(8fe0f000)
CPU0: stack: 8ff20000 - 8ff21000, lowest used address 8ff205e0, stack used:
2592 bytes
PROGRESS CODE: V03020003 I0
PROGRESS CODE: V03020002 I0
PROGRESS CODE: V03020003 I0
PROGRESS CODE: V03020002 I0
PROGRESS CODE: V03020003 I0
PROGRESS CODE: V03021001 I0
PROGRESS CODE: V03040003 I0
PROGRESS CODE: V03040002 I0
PROGRESS CODE: V03040003 I0
PROGRESS CODE: V03040002 I0
I've tried mixing the dsc, dec and fdf files from the edk2-staging and the
CorebootPayloadPkg ones but
no TPM menu in the device manager menu is shown. I'm using
NULL|SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.inf
instead of
NULL|UefiPayloadPkg/Library/Tpm2InstanceLib/Tpm2InstanceLib.inf
Is it correct? Or I have to integrate this library in the CorebootPayloadPkg?
Now I'm trying with the tianocore master version instead of the stable one.
Do you know if there is a TPM menu shown in the device manager menu once is
detected? How the TPM2 is detected?
Do you have a "generic" CustomizationSample/Board?
I think it's more complicated that I expected!
Any hint is welcome!
Jorge
________________________________
De: coreboot <[email protected]> en nombre de Jorge Fernandez
Monteagudo <[email protected]>
Enviado: jueves, 20 de septiembre de 2018 10:31:20
Para: You, Benjamin; [email protected]
Asunto: Re: [coreboot] Tianocore and TPM
Hi Ben,
Adding the 'generic' board it's an interesting option as a starting point to
develop/porting to new boards.
I'll try your suggestion to incorporate the changes from dsc and fdf files to
my current working Tianocore coreboot payload.
I'll report back the results!
Thanks!
Jorge
________________________________
De: You, Benjamin <[email protected]>
Enviado: jueves, 20 de septiembre de 2018 10:21:55
Para: Jorge Fernandez Monteagudo; [email protected]
Asunto: RE: [coreboot] Tianocore and TPM
Hi Jorge,
You could use UEFI Payload's .dsc and .fdf files as a reference and modify the
TianoCore CorebootPayload's .dsc and .fdf files accordingly for those TPM
related modules.
UEFI Payload is under development (in staging area) and hasn't reached the
quality standard required by EDKII master.
On CustomizationSample/Boards, yes it is required. However, a board's content
may be trivial (as in the Qemu folder). Per your suggestion, probably we can
add a board named "generic" that has all the minimalized settings so user won't
have to create a new one if the "generic" one meets the needs.
Thanks!
- ben
From: Jorge Fernandez Monteagudo [mailto:[email protected]]
Sent: Thursday, September 20, 2018 3:24 PM
To: You, Benjamin <[email protected]>; [email protected]
Subject: Re: Tianocore and TPM
Hi Ben!
Thanks for the info! I have one question. Have I to implement a
CustomizationSample/Boards for my board? With the current
tianocore payload I don't have to implement nothing to have a working UEFI...
Thanks!
Jorge
________________________________________
De: You, Benjamin <[email protected]>
Enviado: jueves, 20 de septiembre de 2018 3:42:33
Para: Jorge Fernandez Monteagudo; [email protected]
Asunto: RE: Tianocore and TPM
Hi,
Another note is on the use of
NULL|UefiPayloadPkg/Library/Tpm2InstanceLib/Tpm2InstanceLib.inf. This lib is
not fully populated right now.
Please consider using
NULL|SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.inf depending on
your needs.
Thanks,
- ben
From: coreboot [mailto:[email protected]] On Behalf Of You, Benjamin
Sent: Thursday, September 20, 2018 8:44 AM
To: Jorge Fernandez Monteagudo <[email protected]>; [email protected]
Subject: Re: [coreboot] Tianocore and TPM
Hi Jorge,
The staging UEFI Payload project
(https://github.com/tianocore/edk2-staging/tree/UEFIPayload) has TPM support
(although turned off by default, and using "FTPM" as the name (which needs to
be fixed)).
Please have a look at UefiPayloadPkgIA32X64.dsc for the components under tag
"$(FTPM_ENABLE)". These components mainly do the measuring of firmware
components and log the results.
Also there is parsing logic in Library/PlatformInfoParseLib/ParseLib.c that
parses TPM info in ACPI table passed from Coreboot. (This logic hasn't been
sufficiently verified as this is still a "staging" project).
You might have a try. Please let us know if you see any bugs / problems in
these. You might also use the EDKII mailing list for discussing issues with the
UEFI Payload.
Thanks,
- ben
From: coreboot [mailto:[email protected]] On Behalf Of Jorge
Fernandez Monteagudo
Sent: Wednesday, September 19, 2018 5:24 PM
To: [email protected]
Subject: [coreboot] Tianocore and TPM
Hi all!
I'm trying to enable the TPM2 support in the tianocore payload. The TPM2 device
is working, because I've enabled the DEBUG_TPM and coreboot reports is up. I
guess that I have to modify the 'CorebootPayloadPkgIa32X64.dsc' file to enable
the TPM support but there are so many dependencies. Anybody has a working
tianocore payload with TPM?
Thanks!
--
coreboot mailing list: [email protected]
https://mail.coreboot.org/mailman/listinfo/coreboot
