Hi, On Fri, Mar 25, 2011 at 10:55:21AM -0600, Marc Jones wrote: > >> Signed-off-by: Prakash Punnoor <[email protected]> > > Thanks for the contribution and for the reminder. > > Acked-by: Marc Jones <[email protected]>
Yup, thanks! However, the patch is not quite correct, I think. The last datasheet (from Winbond) for the "W83627DHG" doesn't mention those registers, the superiotool list was correct. However, you likely looked at the new "W83627DHG-P/-PT" datasheet from Nuvoton (which now owns the Winbond Super I/O stuff): http://www.nuvoton.com/NuvotonMOSS/Community/ProductInfo.aspx?tp_GUID=0516ba91-bd6d-436c-9378-a371cd463afb But, this is a different chip from the "W83627DHG". The original Winbond W83627DHG has the ID bytes 0xa0 / 0x2y (y is the revision). The Nuvoton W83627DHG-P/-PT has the IDs 0xb0 / 0x7y (y is the revision). Thus, these are two different chips. Prakash, let us know if you want to work on a patch which reverts your last changes and adds a new entry for the Nuvoton W83627DHG-P/-PT instead. Otherwise I might do it when I have some spare time. But please carefully check all registers and their default values. While many may be similar to the old W83627DHG there may also be various other differences in the W83627DHG-P/-PT. You have to check each value. Thanks, Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
