Re: [coreboot] NULL pointer dereference in search_bus_device()

[Sven Schnelle]

Sven Schnelle <sv...@stackframe.org> writes:

Missed a bracket, sorry:

if (res->flags & IORESOURCE_SUBTRACTIVE) {
      struct bus * subbus;
    for (subbus = curdev->link_list; subbus; subbus = subbus->next) {
                 if (subbus->link_num == IOINDEX_SUBTRACTIVE_LINK(res->index)) {
                     search_bus_resources(subbus, type_mask, type, search, gp);
                     break;
                 }
    }
        continue;
}

> it should be proably something like:
> -----------------------8<-------------------
>
> if (res->flags & IORESOURCE_SUBTRACTIVE) {
>     struct bus * subbus;
>     for (subbus = curdev->link_list; subbus; subbus = subbus->next) {
>                 if (subbus->link_num == IOINDEX_SUBTRACTIVE_LINK(res->index))
>                     search_bus_resources(subbus, type_mask, type, search, gp);
>                  break;
>     }
>        continue;
> }
> -----------------------8<-------------------
>
> Regards,
>
> Sven.

pgpsrAQP5cnyU.pgp
Description: PGP signature

-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot