On Tuesday 16 June 2009 14:14:24 Carl-Daniel Hailfinger wrote:
> On 14.06.2009 16:45, Harald Gutmann wrote:
> > Hello!
> >
> > This little patch activates HIGH_TABLES on M57SLI.
> > I tested it with a recent SeaBios version, and it works.
> >
> > Signed-off-by: Harald Gutmann <[email protected]>
>
> I assume this is a patch created from inside the m57sli directory. If
> that is true, the patch is
> Acked-by: Carl-Daniel Hailfinger <[email protected]>
Your assumption is true, thanks for the review.

> In the future, please send patches created in the root directory of the
> tree (or created in the parent directory of the tree root directory).
> That makes review a lot easier. Thanks.
Noticed.
The same patch once again attached with root directory src/.

> Regards,
> Carl-Daniel

Regards,
Harald


>
> --
> http://www.hailfinger.org/

Index: mainboard/gigabyte/m57sli/Options.lb
===================================================================
--- mainboard/gigabyte/m57sli/Options.lb	(revision 4352)
+++ mainboard/gigabyte/m57sli/Options.lb	(working copy)
@@ -87,6 +87,8 @@
 uses HW_MEM_HOLE_SIZE_AUTO_INC
 uses K8_HT_FREQ_1G_SUPPORT
 
+uses HAVE_HIGH_TABLES
+
 uses HT_CHAIN_UNITID_BASE
 uses HT_CHAIN_END_UNITID_BASE
 uses SB_HT_CHAIN_ON_BUS0
@@ -169,8 +171,11 @@
 ##
 default HAVE_MP_TABLE=1
 
+## HIGH tables support
+default HAVE_HIGH_TABLES=1
+
 ## ACPI tables will be included
-default HAVE_ACPI_TABLES=0
+default HAVE_ACPI_TABLES=1
 
 ##
 ## Build code to export a CMOS option table
@@ -356,10 +361,10 @@
 ## Select power on after power fail setting
 default MAINBOARD_POWER_ON_AFTER_POWER_FAIL="MAINBOARD_POWER_ON"
 
-### End Options.lb
 #
 # CBFS
 #
 #
 default CONFIG_CBFS=0
+### End Options.lb
 end

Attachment: signature.asc
Description: This is a digitally signed message part.

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to