On 22.04.2009 18:00 Uhr, Peter Stuge wrote:
> Stefan Reinauer wrote:
>
>> +++ src/arch/i386/boot/acpi.c (.../trunk/coreboot-v2)
>>
> ..
>
>
>> +#if 0
>> +#if MEM_TRAIN_SEQ != 0
>> + #error "So far it works on AMD and MEM_TRAIN_SEQ == 0"
>> +#endif
>> +
>> +#if _RAMBASE < 0x1F00000
>> + #error "For ACPI RESUME you need to have _RAMBASE at least 31MB"
>> + #error "Chipset support (S3_NVRAM_EARLY and ACPI_IS_WAKEUP_EARLY
>> functions and memory ctrl)"
>> + #error "And coreboot memory reserved in mainboard.c"
>> +#endif
>> +#endif
>>
>
> Why disable these build time checks?
>
>
> //Peter
>
>
Because they don't belong in i386 generic code either.. They're
mainboard or chipset or CPU specific limitations. Many chipsets have no
variable named MEM_TRAIN_SEQ
Stefan
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [email protected] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
