Carl-Daniel Hailfinger wrote:
> Calculate tCL related settings per DIMM in a dual channel setup.

..

> +++ LinuxBIOSv2-asus_m2a-vm/src/northbridge/amd/amdk8/raminit_f.c     
> (Arbeitskopie)
>       /* Make a second pass through the dimms and disable
>        * any that cannot support the selected memclk and cas latency.

This (existing) comment is reassuring.


> +int get_dimm_Trc_clocks(u32 spd_device, const struct mem_param *param)
..
>       if (clocks < DTL_TRC_MIN) {
> +#warning We should die here or at least disable this bank.
> +             printk_notice("update_dimm_Trc: can't refresh fast enough, "
> +                     "want %i clocks, can %i clocks\n", clocks, DTL_TRC_MIN);
>               clocks = DTL_TRC_MIN;
>       }
> +     return clocks;
> +}

This (existing) code not so much. How to combine the two?

Acked-by: Peter Stuge <[email protected]>

--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to